Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.lock should be included in the git repo #84

Closed
bbigras opened this issue Apr 27, 2019 · 1 comment
Closed

Cargo.lock should be included in the git repo #84

bbigras opened this issue Apr 27, 2019 · 1 comment

Comments

@bbigras
Copy link

bbigras commented Apr 27, 2019

If you’re building a non-end product, such as a rust library that other rust packages will depend on, put Cargo.lock in your .gitignore. If you’re building an end product, which are executable like command-line tool or an application, or a system library with crate-type of staticlib or cdylib, check Cargo.lock into git. If you're curious about why that is, see "Why do binaries have Cargo.lock in version control, but not libraries?" in the FAQ.

https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html

@nabijaczleweli
Copy link
Collaborator

nabijaczleweli commented Apr 27, 2019

I've waxed poetic about this before, mainly in nabijaczleweli/cargo-update#50. And, while https has not used a split-lib up to this point, it's something that's always bugged me, and I'll def split it for the next release, so thanks for reminding me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants