Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style] BinExploit | filtering a keyword in BinExploit #791

Open
1 task done
ZizouX0 opened this issue May 11, 2024 · 5 comments
Open
1 task done

[Style] BinExploit | filtering a keyword in BinExploit #791

ZizouX0 opened this issue May 11, 2024 · 5 comments

Comments

@ZizouX0
Copy link
Contributor

ZizouX0 commented May 11, 2024

Describe the bug

the bug appears to be in the keyword filtering functionality of the web application. When you use a keyword to filter the results, the application is expected to highlight or color the keyword in a specific section(top section) of the page . However, the bug is causing the keyword to be highlighted multiple times across the entire page, not just in the intended section.

This could lead to confusion as it misrepresents the locations where the keywords are actually .

To Reproduce

go to 'Resources'
go to ' Tools'
click on 'BinExploit'
click on a keyword from the list provided at the top of the page

Expected Behavior

in my opinion the filtering section and the result section should've been separated maybe in the result section you can just align the keyword and in the filtering section it should remain the same this will help the users and it will improve user Experience

Screenshot/ Video

1222
12223

Code of Conduct

  • I agree to follow this project's Code of Conduct
Copy link

It's great having you contribute to this project

🌟 Welcome to the community 🌟

  • If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
  • You should join our Discord chat and our GitHub Organisation.
  • We help and encourage each other to contribute to open source little and often 😄.
  • Any questions let us know.

@ArkadiK94 ArkadiK94 changed the title filtering a keyword in BinExploit [Style] BinExploit | filtering a keyword in BinExploit May 11, 2024
@ArkadiK94
Copy link
Collaborator

@ZizouX0 it is not a bug it was intended to be in this way.
@kabir0x23 what do you think about changing the way it shows the active button in the main section?

@kabir0x23
Copy link
Member

yes good idea,

yes it was intended, but it is not good to do highlights in data i think

@ArkadiK94
Copy link
Collaborator

@kabir0x23 what do you mean? he/she means that only on top section the button should be orange and not in main section as it is now. If I understand it is right.
@ZizouX0 did you mean italic instead of align? or could you explain your solution? in addition, would you like to handle it?

@kabir0x23
Copy link
Member

@kabir0x23 what do you mean? he/she means that only on top section the button should be orange and not in main section as it is now. If I understand it is right. @ZizouX0 did you mean italic instead of align? or could you explain your solution? in addition, would you like to handle it?

yes top section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants