Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsiveness fixes in events page #203

Merged
merged 7 commits into from Oct 16, 2022

Conversation

nirajpdn
Copy link
Contributor

@nirajpdn nirajpdn commented Oct 16, 2022

closes #185

Fixes Issue #185

Changes proposed

  • Fixed max-width of the container that wraps the Today's , Upcoming & Past events
  • Fixed static width
  • Fixed margin and padding in the layout
  • Optimize css

Screenshots

Before

Screen Shot 2022-10-16 at 23 50 51

After

Screen Shot 2022-10-17 at 00 05 51

Note to reviewers

Please review the changes and let me know if anything i have missed to update further.

Code of Conduct

  • By submitting this pull request, I confirm I've read and complied with the CoC 🖖

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

You can also join our Discord community.
Feel free to check out other cool repositories of the Thecyberworld.
Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

🌟 Welcome to the community 🌟

  • If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
  • You should join our Discord chat and our GitHub Organisation.
  • We help and encourage each other to contribute to open source little and often 😄.
  • Any questions let us know.

Copy link
Member

@kabir0x23 kabir0x23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is an event today:
image

If we keep adding data in today's section, then past section will start going

You can add today's date in the data to test this:
like:
image

@nirajpdn
Copy link
Contributor Author

If there is an event today: image

If we keep adding data in today's section, then past section will start going

You can add today's date in the data to test this: like: image

Here is a screenshot

Screen Shot 2022-10-17 at 01 09 56

Copy link
Member

@kabir0x23 kabir0x23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Thanks for contributing to this project.

If you want to contribute more then must check out other open-source projects and communities:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Non-responsive Events page
2 participants