Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Sidebar #128

Closed
1 task done
kabir0x23 opened this issue Oct 5, 2022 · 7 comments · Fixed by #171
Closed
1 task done

[BUG] Sidebar #128

kabir0x23 opened this issue Oct 5, 2022 · 7 comments · Fixed by #171

Comments

@kabir0x23
Copy link
Member

kabir0x23 commented Oct 5, 2022

Describe the bug

When we click on the sidebar-nav item, it automatically closes the sidebar and opens the new page.
whereas when we click on the dropdown nav-items, it doen;t close the sidebar automatically
under Learn navitem:

  • navitem > learn
  • navitem > learn > prep

drawing

### To Reproduce
  • navitem > events:
    • works.
  • navitem > learn > prep > quiz:
    • does not work.

Expected Behavior

When we click on:

  • navitem > learn > prep > quiz:

it should work the same as events and blogs.

Screenshot/ Video

screenshot:
drawing

video:

thecyberworld.Firefox.Developer.Edition.2022-10-05.16-38-34_Trim.mp4

Code of Conduct

  • I agree to follow this project's Code of Conduct
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

It's great having you contribute to this project

🌟 Welcome to the community 🌟

  • If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
  • You should join our Discord chat and our GitHub Organisation.
  • We help and encourage each other to contribute to open source little and often 😄.
  • Any questions let us know.

@kabir0x23
Copy link
Member Author

@saimaheshtaduri this was working fine before when we are having different navbars and when we were on the homepage.
but now as we have only the same bar. now sidebar is not getting toggle.

@saimaheshtaduri
Copy link
Contributor

I will work on this. Please assign me @kabir0x23

@kabir0x23
Copy link
Member Author

Awesome, assigned 🚀

@abdullmustyy
Copy link
Contributor

Hi @kabir0x23
I'm back, and I've resolved this bug! 😃

Untitled.mp4

What do you think?

@kabir0x23
Copy link
Member Author

Nice @abdullmustyy
Looking good

@abdullmustyy
Copy link
Contributor

Good morning @kabir0x23
I have just made a PR, please review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants