Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Base Class of TwitterObject from Context and BaseMetrics #146

Closed
thedavecarroll opened this issue Oct 30, 2022 · 0 comments
Closed

Remove Base Class of TwitterObject from Context and BaseMetrics #146

thedavecarroll opened this issue Oct 30, 2022 · 0 comments
Assignees
@thedavecarroll
Labels
CHANGELOG.3.Removed CHANGELOG Entry Type enhancement New feature or request
Milestone
Release 0.8.0

Comments

@thedavecarroll
Copy link
Owner

thedavecarroll commented Oct 30, 2022 •
edited

The classes from BluebirdPS.APIV2.TweetInfo.Context and classes that inherit from BaseMetrics included the OriginalObject property and GetOriginalObject() method. This information is stored within the top-level (Tweet, User, Media) class instances and it was deemed unnecessary.

Remove TwitterObject inherited class from:

  • BluebirdPS.APIV2.Objects.BaseMetrics
  • BluebirdPS.APIV2.Objects.WithheldContent
  • BluebirdPS.APIV2.TweetInfo.Context.ContextAnnotation
  • BluebirdPS.APIV2.TweetInfo.Context.Domain
  • BluebirdPS.APIV2.TweetInfo.Context.Entity

Remove OriginalObject property from the following:

  • BluebirdPS.APIV2.TweetInfo.Metrics.NonPublic
  • BluebirdPS.APIV2.TweetInfo.Metrics.Organic
  • BluebirdPS.APIV2.TweetInfo.Metrics.Promoted
  • BluebirdPS.APIV2.TweetInfo.Metrics.Public
  • BluebirdPS.APIV2.UserInfo.Metrics.Public
  • BluebirdPS.APIV2.MediaInfo.Metrics.NonPublic
  • BluebirdPS.APIV2.MediaInfo.Metrics.Organic
  • BluebirdPS.APIV2.MediaInfo.Metrics.Promoted
  • BluebirdPS.APIV2.MediaInfo.Metrics.Public
@thedavecarroll thedavecarroll added enhancement New feature or request CHANGELOG.3.Removed CHANGELOG Entry Type labels Oct 30, 2022
@thedavecarroll thedavecarroll added this to the Release 0.8.0 milestone Oct 30, 2022
@thedavecarroll thedavecarroll self-assigned this Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thedavecarroll thedavecarroll

Labels
CHANGELOG.3.Removed CHANGELOG Entry Type enhancement New feature or request
Projects
None yet
Milestone
Release 0.8.0
Development

No branches or pull requests
1 participant
@thedavecarroll