Add support for PHP 7.4

[owenvoke]

This updates Larasail to use PHP 7.4 as the default version of PHP. It also adds an additional argument (php73) for installing PHP 7.3.

[wimurk]

+1

[butaminas]

Doesn't work for me. Still installs PHP 7.2.

[wimurk]

@pxgamer set it as default. 7.4 is already on the way.

[owenvoke]

@butaminas, are you installing from my fork (and branch)? Or the main repository? 🤔

This PR hasn't been merged so the official Larasail won't use PHP 7.3 yet.

[butaminas]

@butaminas, are you installing from my fork (and branch)? Or the main repository? 🤔

This PR hasn't been merged so the official Larasail won't use PHP 7.3 yet.

It's weird, because I've installed it from your branch. I've seen few times it was doing something with php 7.3 but most of the time it was installing and configuring 7.2. After the installation I did php -v and it was 7.2.

I have now upgraded to php 7.3 manually.

I was using Ubuntu 16.04.

[owenvoke]

I've tested on a clean droplet (Ubuntu 18.04) and it installed PHP 7.3 as expected. 🤔

curl -sL https://github.com/pxgamer/larasail/archive/feature/php-7.3.tar.gz | tar xz && source larasail-feature-php-7.3/install

However, this project seems kind of dead at the moment. 🤔

[butaminas]

@pxgamer strange. Could it be the 16.04? Or perhaps I messed it up somehow.

Yeah, the project seems to be dead, though it is still an awesome tool. Thanks for trying to keep it alive.

[wimurk]

It looks dead indeed. Maybe someone can fork the project and keep it maintained?

[bobbyiliev]

PHP 7.3 is not yet available in the default Ubuntu 18.04 repository.

In order for this to work you need to add a stage to install the software-properties-common package and add the ppa:ondrej/php repository:

sudo apt-get install software-properties-common
sudo add-apt-repository ppa:ondrej/php
sudo apt-get update
sudo apt-get upgrade
sudo apt-get install -y php7.3-cli

[owenvoke]

@bobbyiliev, if we're going to add this, would it be better to just change this to use PHP 7.4 by default, and add php73 as an argument? And I'll add the APT repository 👍

[bobbyiliev]

@owenvoke Yes that is a good point, I think that PHP 7.4 sounds good, this would also close the #23 issue.

[owenvoke]

@bobbyiliev, I've updated this to use PHP 7.4 by default with a php73 argument available.

Looking at

larasail/.larasail/setup

Lines 72 to 75 in ed5a239

	sudo apt-get install -y software-properties-common
	sudo add-apt-repository -y ppa:ondrej/php
	sudo apt-get -y update
	sudo apt-get -y upgrade

, it appears to already setup the ondrej/php repository so I don't think any changes need to be applied on that front?