Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

issue in package JSON #17

Open
kookma opened this issue Mar 2, 2020 · 3 comments
Open

issue in package JSON #17

kookma opened this issue Mar 2, 2020 · 3 comments

Comments

@kookma
Copy link

kookma commented Mar 2, 2020

There are some typos in https://github.com/TheDiveO/ThirdFlow/blob/master/package.json
Which makes it fails on Windows system

Line 20 -26

    "start": "tiddlywiki editions/develop --verbose --server $npm_package_config_port $:/core/save/all text/plain text/html & echo $! > tw.pid",
    "stop": "kill `cat tw.pid` && rm tw.pid",
    "winstart": "start \"ThirdFlow Develop\" cmd /c tiddlywiki editions/develop --verbose --server %npm_package_config_port $:/core/save/all text/plain text/html",
    "winstop": "taskkill /fi \"WINDOWTITLE eq ThirdFlow Develop\"",
    "develop": "tiddlywiki editions/develop --verbose --server $npm_package_config_port $:/core/save/all text/plain text/html",
    "release": "tiddlywiki editions/release --verbose --build release",
    "test": "tiddlywiki editions/release --verbose"

for windows system environmental variable escaped with % % so in any of avobe command to be used on Windows, $npm_package_config_port shall change to %npm_package_config_port %

See also: https://stackoverflow.com/questions/39793500/how-to-use-variables-in-npm-scripts-on-windows

Please correct this also in TiddlywikiPluginSkleton.

@kookma
Copy link
Author

kookma commented Mar 2, 2020

Note:
I also recommend to use develop, release for all OS.

@thediveo
Copy link
Owner

thediveo commented Mar 4, 2020

Good catch! Thank you for that.

I have to admit that I don't spend any private time on Windows, so Windows only when my employer pays me for at my daytime job. And even there, most work nowadays happens in VMs, on remote CI chains, and on platform-agnostic web apps, because Windows causes so much unnecessary costs.

@kookma
Copy link
Author

kookma commented Mar 5, 2020

Thank you @thediveo
I would be happy to help whenever you like to test on Windows!
I use on daily basis this great plugin!

One more question

As I explained in another issue, ThirdFlow does not create the plugin.info
This is essential when you want to distribute the plugin as its source folder look at
https://tiddlywiki.com/dev/#Developing%20plugins%20using%20Node.js%20and%20GitHub

I would appreciate if ThirdFlow can create the plugin.info when one issues the npm run release

What do you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants