Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM history from other user is not restored correctly #265

Closed
cwc opened this issue Aug 12, 2013 · 4 comments
Closed

PM history from other user is not restored correctly #265

cwc opened this issue Aug 12, 2013 · 4 comments

Comments

@cwc
Copy link
Contributor

cwc commented Aug 12, 2013

To replicate:

  1. Have a PM convo with another IRC user
  2. Close the PM chat window
  3. PM the same user, or have them PM you, in order to re-open the PM chat window

Result: only your messages from the previous convo will be restored and visible in the window

Expected: both sides of the convo will be restored

@lukespragg
Copy link

I haven't tried PMs yet, but I have found that history in general is not restored when logging back in with bouncer mode enabled.

@cwc
Copy link
Contributor Author

cwc commented Sep 15, 2013

For the record, the behavior I'm seeing occurs in normal (not bouncer) mode.

@kparaju
Copy link
Contributor

kparaju commented Sep 27, 2013

@wulfspider: the bouncer is not writing any data to the database.

This seems to be because of line 83 and 96 in irclink.js. If you change the lines from if (!userConn.temporary) { to if (true) { in both places it will start logging.

This is a temporary fix around the logging issue (does not seem to fix this bug). Looks like it's also related to #268.

@thedjpetersen
Copy link
Owner

Subway is in the process of being refactored - this should be fixed in the refactor branch. If you test it and the issue still persists could you reopen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants