Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid layout issues #7

Closed
akavlie opened this issue Jan 7, 2012 · 10 comments
Closed

Fluid layout issues #7

akavlie opened this issue Jan 7, 2012 · 10 comments
Labels
Milestone

Comments

@akavlie
Copy link
Contributor

akavlie commented Jan 7, 2012

So all of the major containers in the current layout are expressed with percentage sizing. The fluid layout you get with that is great, but it creates problems. See What happens to the User List / channel headers as you shrink vertically for example.

I think the only good solution here is JS-based resizing, with elements like the input container, title bars etc. getting fixed vertical sizing, and other elements getting fixed minimums as appropriate.

@ghost ghost assigned thedjpetersen Jan 7, 2012
@akavlie
Copy link
Contributor Author

akavlie commented Jan 7, 2012

btw, I have a decent solution for the JS resizing on window resize in web-irc.

@akavlie
Copy link
Contributor Author

akavlie commented Jan 14, 2012

I think the chat contents should resize fluidly, but most other elements would be better off with fixed sizing.

@thedjpetersen
Copy link
Owner

The only real problem is with the logo correct?

@akavlie
Copy link
Contributor Author

akavlie commented Jan 15, 2012

Yes and no... the sidebar needs a minimum width to show the logo, as well as channel names and unread counts.

@thedjpetersen
Copy link
Owner

At what resolution would the percentage resolution become a problem?

@akavlie
Copy link
Contributor Author

akavlie commented Jan 18, 2012

I just tested it out, and it starts cutting off when the window is about 645px wide. Granted, that's narrower than users would typically be sizing their browser windows (other than on mobile).

@akavlie
Copy link
Contributor Author

akavlie commented Jan 20, 2012

If you don't have any objections, I think I'll try a version of the layout without percentage sizing, and port my window resizing code from web-irc.

@ghost ghost assigned akavlie Jan 20, 2012
@thedjpetersen
Copy link
Owner

I'll checkout the code and get back to you as soon as possible.

@akavlie
Copy link
Contributor Author

akavlie commented Jan 26, 2012

any thoughts?

@akavlie
Copy link
Contributor Author

akavlie commented Feb 3, 2012

Changed top bars & input to be fixed height with absolute positioning. I think the fluid sizing can cause issues at very small horizontal sizes as well, but that's a relatively minor issue, and not likely to occur with normal usage.

@akavlie akavlie closed this as completed Feb 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants