-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluid layout issues #7
Comments
btw, I have a decent solution for the JS resizing on window resize in web-irc. |
I think the chat contents should resize fluidly, but most other elements would be better off with fixed sizing. |
The only real problem is with the logo correct? |
Yes and no... the sidebar needs a minimum width to show the logo, as well as channel names and unread counts. |
At what resolution would the percentage resolution become a problem? |
I just tested it out, and it starts cutting off when the window is about 645px wide. Granted, that's narrower than users would typically be sizing their browser windows (other than on mobile). |
If you don't have any objections, I think I'll try a version of the layout without percentage sizing, and port my window resizing code from web-irc. |
I'll checkout the code and get back to you as soon as possible. |
any thoughts? |
Changed top bars & input to be fixed height with absolute positioning. I think the fluid sizing can cause issues at very small horizontal sizes as well, but that's a relatively minor issue, and not likely to occur with normal usage. |
So all of the major containers in the current layout are expressed with percentage sizing. The fluid layout you get with that is great, but it creates problems. See What happens to the User List / channel headers as you shrink vertically for example.
I think the only good solution here is JS-based resizing, with elements like the input container, title bars etc. getting fixed vertical sizing, and other elements getting fixed minimums as appropriate.
The text was updated successfully, but these errors were encountered: