Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ed::Suspend es::Resume break docking branch of ImGui #230

Closed
gleblebedev opened this issue May 30, 2023 · 8 comments
Closed

ed::Suspend es::Resume break docking branch of ImGui #230

gleblebedev opened this issue May 30, 2023 · 8 comments

Comments

@gleblebedev
Copy link

Hey... I'm trying to use the node editor in a game engine. The engine takes imgui from a docking branch.

I need to use the Suspend/Resume for popups but it breaks the editor in a wired ways. For example: https://gyazo.com/3098ab2f4cf8080dc4d48de6e25b28de

I've noticed that the version you have in the repo uses CurrentWindow then LastItemData. Is it something related to my issue? Any ideas how can I fix the editor?

@TLaviron
Copy link

I'm running into the same issue, when using the latest version for the docking-layout branch here https://github.com/thedmd/imgui/tree/docking-layout which is based on imgui version 1.89.6.
This was running fine with version 1.85 from the (original) docking branch, so I'll try reverting to an earlier version until this is fixed.

@AdotBdot
Copy link

I have the same issue and don't know how to revert to an earlier version of docking branch.

@gleblebedev
Copy link
Author

The issue I had was with border evaluation. To fix it I made a workaround that skips one frame before calling NavigateToContent

@AdotBdot
Copy link

@gleblebedev Could you describe more precisely how to make this workaround?

@Sage-of-Mirrors
Copy link

#237 This is the same issue I'm having. I don't know how to fix it.

@Sage-of-Mirrors
Copy link

Seems like a user by the name of glscopeclient found a workaround for this issue in their fork. The fix works for me, so that's what I'll be using for now.

@Namek
Copy link

Namek commented Aug 7, 2023

#205

@thedmd
Copy link
Owner

thedmd commented Sep 1, 2023

Fix landed on develop. Thanks for your patience.

@thedmd thedmd closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants