You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd suggest adding a keep_symlinks option. The zip command needs an additional --symlinks to avoid copying the file pointed to, instead of just archiving the symlink.
Tar does this by default.
This behavior makes sense when you are packaging stuff for release (so I'd even consider making this default to True).
The text was updated successfully, but these errors were encountered:
Hey @mcourteaux.
I am a little hesitant to make that a default behavior, so I encourage you to use the custom parameter instead that can be used to pass any additional arguments to the executed command.
Yeah, for me I was packaging a lot of *.so files double or tripple (just because of the way the symlinking with the version numbers works). I even tried --symlinks in custom, but it didn't work. Perhaps, the docker image has a zip-executable that doesn't have that function?
That's why I switched to .tar.gz for the linux release.
@mcourteaux you may try again with the --symlinks custom parameter as there was an issue with it for the zip command as that was also fixed in the latest release.
Aaah that most likely explains the behavior I observed! Good catch! To be honest, I don't have the need to test it again, but the code fix you linked will almost certainly make it work indeed. Thanks for looking into this!
I'd suggest adding a
keep_symlinks
option. Thezip
command needs an additional--symlinks
to avoid copying the file pointed to, instead of just archiving the symlink.Tar does this by default.
This behavior makes sense when you are packaging stuff for release (so I'd even consider making this default to True).
The text was updated successfully, but these errors were encountered: