We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The loss function currently implement is -(oloss + nloss).mean()
-(oloss + nloss).mean()
It should be (-oloss + nloss).mean()
(-oloss + nloss).mean()
You want to minimize the distance between "positive samples" and maximize the distance between "negative samples".
The text was updated successfully, but these errors were encountered:
As you would've noticed, there's .neg() chain at the end of nvectors definition (https://github.com/theeluwin/pytorch-sgns/blob/master/model.py#L72). But this does seem confusing. I'll fix it to be more verbose someday.
.neg()
nvectors
Sorry, something went wrong.
Yes. I noticed it. Thanks for the response.
No branches or pull requests
The loss function currently implement is
-(oloss + nloss).mean()
It should be
(-oloss + nloss).mean()
You want to minimize the distance between "positive samples" and maximize the distance between "negative samples".
The text was updated successfully, but these errors were encountered: