Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale_app(...) calls update_app(...) with only 1 argument #13

Closed
anthonyrisinger opened this issue Nov 14, 2014 · 2 comments
Closed

scale_app(...) calls update_app(...) with only 1 argument #13

anthonyrisinger opened this issue Nov 14, 2014 · 2 comments

Comments

@anthonyrisinger
Copy link

which fails with:

TypeError: update_app() takes at least 3 arguments (2 given)

suggest making update_app accept app_id, app, or both.

@mbabineau
Copy link
Member

Thanks for reporting this!

16f3d14 / 0.6.5 fixed it for me. Can you confirm on your end?

@anthonyrisinger
Copy link
Author

yep, works fine for me! thanks for your work here BTW... def saved me some time :)

somewhat [un]related, but i noticed i must null out the app.version property, else marathon won't update the app by creating a new version:

app = c.get_app(ident)
app.instances = 10
app.version = None
c.update_app(app.id, app)

i vaguely recall reading about this in the marathon docs, but i can't find it ATM... does this sound familiar? it is definitely a little unexpected from a development POV, but the way you implemented this change avoids the issue by creating a new MarathonApp(...). if it's new, the library may need to help the user out a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants