Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure branch protection on stable branches #2646

Open
ekohl opened this issue Dec 20, 2023 · 3 comments
Open

Configure branch protection on stable branches #2646

ekohl opened this issue Dec 20, 2023 · 3 comments

Comments

@ekohl
Copy link
Member

ekohl commented Dec 20, 2023

We should configure the project to not allow force pushes to "X.Y" & "master" branches.

Originally posted by @maximiliankolb in #2644 (comment)

I've created an empty rule for branches matching *.* which should prevent force pushes.

The question is, how far do we want to go with this? We can also mandate a PR, but that prevents cherry picks as we do them today.

@maximiliankolb
Copy link
Contributor

Thanks for creating this rule.

I think preventing force pushes on stable branches is the perfect balance; preventing cherry-picks would really impact my workflow.

IMHO we can close this issue with "done" but lets hear other options too.

@ekohl
Copy link
Member Author

ekohl commented Dec 20, 2023

I'll note I didn't test this because of the risk. I'd like to keep it open and discuss this during the next docs meeting.

@adamlazik1
Copy link
Contributor

I also think preventing force pushes and allowing regular pushes is a good balance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants