Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

friendly reminder: do not forget to cherry-pick to 3.10! #2820

Closed
maximiliankolb opened this issue Feb 22, 2024 · 3 comments · Fixed by #2821
Closed

friendly reminder: do not forget to cherry-pick to 3.10! #2820

maximiliankolb opened this issue Feb 22, 2024 · 3 comments · Fixed by #2821

Comments

@maximiliankolb
Copy link
Contributor

hi @theforeman/documentation-write

I just realized while opening a PR: we already have a "3.10" branch but it's not part of our template yet. I will check if we've missed some cherry-picked and report back. This issuse serves as a friendly reminder to all maintainers performing cherry-picks :)

✌️

@maximiliankolb
Copy link
Contributor Author

I have cherry-picked all commits since Feb 15th/the commit "Revert ...":

$ git diff master
diff --git a/guides/common/attributes.adoc b/guides/common/attributes.adoc
index b20e5b5a24..b1c1b18935 100644
--- a/guides/common/attributes.adoc
+++ b/guides/common/attributes.adoc
@@ -1,11 +1,11 @@
 // Document state: "nightly" for master, "stable" for last two releases,
 // "unsupported" for the rest and "satellite" for satellite build
-:DocState: nightly
+:DocState: unsupported
 
 // Version numbers
 :ProjectVersion: nightly
-:ProjectVersionPrevious: 3.9
-:KatelloVersion: nightly
+:ProjectVersionPrevious: 3.10
+:KatelloVersion: 4.12

This looks correct to me unless there are some commits on master that are explicitely "3.11+ only".

PR: #2821 as expected, there were no merge conflicts.

@maximiliankolb
Copy link
Contributor Author

I have also contacted Griffin who pointed to to the proper place to add an action item: theforeman/theforeman-rel-eng#348

@maximiliankolb
Copy link
Contributor Author

Merged #2821 which leaves us with the following diff:

$ git diff --name-only master 3.10
guides/common/attributes.adoc

Closing this issue because the follow-up discussion will take place in theforeman/theforeman-rel-eng#348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant