fix: Disk controller setup does not add hard disk other than virtio0 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manisha15
force-pushed
the
add_hdd_device_limit
branch
2 times, most recently
from
5acdb9f
to
5182cff
Compare
sbernhard
reviewed
Dec 19, 2023
| @@ -26,7 +26,10 @@ along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>. %> | |||
| <%= f.hidden_field :storage_type %> | |||
| <%= select_f f, :storage, compute_resource.storages(node_id), :storage, :storage, { }, :label => _('Storage'), :label_size => "col-md-2" %> | |||
| <%= select_f f, :controller, proxmox_controllers_map, :id, :name, { }, :label => _('Controller'), :label_size => "col-md-2", :disabled => !new_volume, :onchange => 'controllerSelected(this)' %> | |||
| <%= text_f f, :device, :label => _('Device'), :label_size => "col-md-2", :disabled => !new_volume, :'data-min' => 0, :'data-soft-max' => proxmox_max_device(f.object.controller), :onchange => 'deviceSelected(this)' %> | |||
| <div> | |||
| <%= text_f f, :device, :label => _('Device'), :label_size => "col-md-2", :disabled => !new_volume, :'data-min' => 0, :'data-soft-max' => proxmox_max_device(f.object.controller), :onchange => 'deviceSelected(this)' %> | |||
There was a problem hiding this comment.
the data-min and data-soft-max are absolute as they are used by the limitedSpinner, right?
sbernhard
reviewed
Dec 19, 2023
| var submitButton = $(item).closest('form').find('[data-disable-with]'); | ||
| if (!isNaN(maxLimit) && !isNaN(deviceNumber) && deviceNumber > maxLimit) { | ||
| if (warningContainer.length === 0) { | ||
| warningContainer = $('<div class="warning-container" style="color: red;"><span style="color: red;">⚠</span> Warning: Value exceeds the maximum limit of ' + maxLimit + '.</div>'); |
There was a problem hiding this comment.
can you set the warning-container parameter (styles) and the internal <span style....) in the app/views/compute_resources_vms/form/proxmox/server/_volume_hard_disk.html.erb and just set the text?
There was a problem hiding this comment.
... we will change this after swiching the form to react.
Manisha15
force-pushed
the
add_hdd_device_limit
branch
from
5182cff
to
9bd8f87
Compare
sbernhard
approved these changes
Dec 19, 2023
Manisha15
added a commit
to ATIX-AG/foreman_fog_proxmox
that referenced
this pull request
Dec 19, 2023
Manisha15
added a commit
that referenced
this pull request
Dec 19, 2023
Manisha15
added a commit
to ATIX-AG/foreman_fog_proxmox
that referenced
this pull request
Dec 19, 2023
Manisha15
added a commit
that referenced
this pull request
Dec 19, 2023
This was referenced Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.