link hosts and vms by lower case MAC + fix 500 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hedius
changed the title
ekohl
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxmox 7.1-10
Lastest fog_proxmox
Latest stable foreman: 3.1.2
I've found the following problem while linking an existing host to a VM
The puppet facts store the MAC in lower case.
The proxmox compute resource (this plugin) pulls the MAC in upper case from the Proxmox API (or Proxmox provides it in upper case)
Therefore, it is not possible to link an existing host with a proxmox host. (Since the comparison is case-sensitive)
The attached commit converts both values to lower case before attempting to associate the different objects. (Works again)
Furthermore, d30e1c4 converts the identity (int) to a string to fix a 500 when clicking on the “Associate VMs” button. Similar to #220