Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 and Protobuf #17

Closed
fdan opened this issue Aug 16, 2020 · 3 comments
Closed

Python3 and Protobuf #17

fdan opened this issue Aug 16, 2020 · 3 comments

Comments

@fdan
Copy link

fdan commented Aug 16, 2020

Hi folks,

I'm modifying the server to run with Python3, as my ML environments require it.

I think I may have ran into some issues with protobuf. In my server output, I see the following:

Server -> Listening on port: 55555
Server -> Receiving message of size: 6
Server -> 6 bytes read
Server -> Message parsed
Server -> Received info request
Server -> Serializing message
Server -> Sending response message of size: 98
Server -> -----------------------------------------------

But the client output says, reporting it read data of size 0, instead of 98

Client -> Connected to 172.17.0.2
Client -> Sending info request
Client -> Created message
Client -> Serialized message
Client -> Created char array of length 6
Client -> Copied to char array
Client -> Message sent
Client -> Reading header data
Client -> Reading data of size: 0
Client -> Deserializing message
Client -> Closed connection

This is my first time using protobuf, so I thought I'd just enquire if there's anything obvious I should be looking for in terms of why it works with Python2 and not Python3,

cheers

@ringdk
Copy link
Contributor

ringdk commented Aug 17, 2020 via email

@johannabar
Copy link
Collaborator

Hi there, we have actually migrated the server from python2 to python3 in May!

You can pull the latest version of this repo which is by default in python3 (and still python2 compatible). If you previously built the python2 dockerfile, you will need to rebuild your python3 Docker image Plugins/Server/Dockerfile following the installation instructions and then it should work fine. Please let us know if you face any more issues!

@fdan
Copy link
Author

fdan commented Aug 19, 2020

Ahah, my bad, I cloned the repo before then and had neglected to pull for a while, will check out now.

@fdan fdan closed this as completed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants