You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We encountered an issue trying to publish graphql-voyager to the organization's package registry.
It's a single-repo (as opposed to a monorepo), however it contains an example directory which has a package.json file in it.
Current Behaviour
The transparent publishing script assumes that this single-repo is a monorepo, due to the sub directory package.json files. Because of this it does not allow the root package to be published.
Desired Behaviour
The script should give the option for the root package to be published, despite the presence of sub-packages.
In the GraphQL Voyager case this would allow publishing of the root package. The example packages could also be published by setting private: false in their package.json.
This would also give monorepo's the ability to publish their root package. This is not typically desired, however giving the option to do so does not seem to be particularly harmful.
The text was updated successfully, but these errors were encountered:
jgnieuwhof
changed the title
馃悰 handling a single-repo with sub-directory package.json files
馃悰 cannot publish a repo with sub-directory package.jsons
Dec 19, 2019
jgnieuwhof
changed the title
馃悰 cannot publish a repo with sub-directory package.jsons
馃悰 cannot publish a single-repo with sub-packages
Dec 19, 2019
I did try ignoring the examples directory, but unfortunately the part of the script that ignores those packages is separate from the part of the script that checks for a monorepo (@minkimcello may have more details on that).
This issue may be something that magically disappears, or is far easier to tackle, after the bash -> JS rewrite.
We encountered an issue trying to publish graphql-voyager to the organization's package registry.
It's a single-repo (as opposed to a monorepo), however it contains an
example
directory which has apackage.json
file in it.Current Behaviour
The transparent publishing script assumes that this single-repo is a monorepo, due to the sub directory
package.json
files. Because of this it does not allow the root package to be published.Desired Behaviour
The script should give the option for the root package to be published, despite the presence of sub-packages.
In the GraphQL Voyager case this would allow publishing of the root package. The example packages could also be published by setting
private: false
in theirpackage.json
.This would also give monorepo's the ability to publish their root package. This is not typically desired, however giving the option to do so does not seem to be particularly harmful.
The text was updated successfully, but these errors were encountered: