Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 cannot publish a single-repo with sub-packages #49

Closed
jgnieuwhof opened this issue Dec 19, 2019 · 2 comments 路 Fixed by #62
Closed

馃悰 cannot publish a single-repo with sub-packages #49

jgnieuwhof opened this issue Dec 19, 2019 · 2 comments 路 Fixed by #62
Labels

Comments

@jgnieuwhof
Copy link

jgnieuwhof commented Dec 19, 2019

We encountered an issue trying to publish graphql-voyager to the organization's package registry.

It's a single-repo (as opposed to a monorepo), however it contains an example directory which has a package.json file in it.

Current Behaviour

The transparent publishing script assumes that this single-repo is a monorepo, due to the sub directory package.json files. Because of this it does not allow the root package to be published.

Desired Behaviour

The script should give the option for the root package to be published, despite the presence of sub-packages.

In the GraphQL Voyager case this would allow publishing of the root package. The example packages could also be published by setting private: false in their package.json.

This would also give monorepo's the ability to publish their root package. This is not typically desired, however giving the option to do so does not seem to be particularly harmful.

@jgnieuwhof jgnieuwhof changed the title 馃悰 handling a single-repo with sub-directory package.json files 馃悰 cannot publish a repo with sub-directory package.jsons Dec 19, 2019
@jgnieuwhof jgnieuwhof changed the title 馃悰 cannot publish a repo with sub-directory package.jsons 馃悰 cannot publish a single-repo with sub-packages Dec 19, 2019
@cowboyd
Copy link
Member

cowboyd commented Jan 14, 2020

If you ignore the examples directory does it then pick up the root?

@jgnieuwhof
Copy link
Author

I did try ignoring the examples directory, but unfortunately the part of the script that ignores those packages is separate from the part of the script that checks for a monorepo (@minkimcello may have more details on that).

This issue may be something that magically disappears, or is far easier to tackle, after the bash -> JS rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants