Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with ember 2.15 due to @glimmer/runtime change #44

Closed
kturney opened this issue Sep 1, 2017 · 2 comments
Closed

Fails with ember 2.15 due to @glimmer/runtime change #44

kturney opened this issue Sep 1, 2017 · 2 comments

Comments

@kturney
Copy link

kturney commented Sep 1, 2017

Version of ember-let: 0.6.0

Ember Version / Ember CLI Version:

Ember Version: 2.15.0
Ember CLI Version: 2.15.0

Expected Behavior

ember-let should still work

Actual Behavior

ember-let blows up with

TypeError: compileArgs is not a function
    at register.js:33
    at Blocks.compile (runtime.js:4415)
    at runtime.js:4067
    at Compilers.compile (runtime.js:3958)
    at compileStatement (runtime.js:4714)
    at compileStatements (runtime.js:4719)
    at CompilableTemplate.compileStatic (runtime.js:4744)
    at runtime.js:845
    at AppendOpcodes.evaluate (runtime.js:70)
    at VM.next (runtime.js:7244)

It seems the @glimmer/runtime API used at

let args = compileArgs(params, hash, builder);
has changed.

Steps To Reproduce:

  1. upgrade to ember 2.15

Ember Twiddle / Example repo / Failing test:

I tried to make a twiddle but looks like ember 2.15 isn't supported yet.

@kturney
Copy link
Author

kturney commented Sep 1, 2017

oh. looks like this is fixed by #43

@HeroicEric
Copy link
Contributor

This should be fixed by #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants