Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: collapse every section #162

Merged
merged 2 commits into from
Jul 10, 2021
Merged

feat: collapse every section #162

merged 2 commits into from
Jul 10, 2021

Conversation

Finkregh
Copy link
Contributor

@Finkregh Finkregh commented Jul 8, 2021

This allows setting .Site.Params.GeekdocCollapseAllSections which then
behaves as if you would have set .Page.Params.geekdocCollapseSection
in all sections.

It is a hard positive switch, so you can not override it per section
once enabled.

@Finkregh
feat: collapse every section
30a094b 
This allows setting `.Site.Params.GeekdocCollapseAllSections` which then
behaves as if you would have set `.Page.Params.geekdocCollapseSection`
in all sections.

It is a hard positive switch, so you can not override it per section
once enabled.
@thegeeklab-bot
Copy link

thegeeklab-bot commented Jul 8, 2021 •
edited

LHCI Report Overview

Report URL Performance Accessibility Best-Practices SEO PWA
Link http://localhost:42379/ 89 % 100 % 100 % 97 % 30 %
Link http://localhost:42379/404.html 84 % 100 % 100 % 100 % 30 %
Link http://localhost:42379/posts/ 89 % 100 % 100 % 100 % 30 %

@xoxys
Copy link
Member

xoxys commented Jul 8, 2021

Thanks for your contribution!

xoxys
xoxys requested changes Jul 8, 2021
View reviewed changes
Copy link
Member

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small issue with the current implementation, as the check for a parent/sub is also bypassed. As the result, the collapsible class handling is getting applied to every page:

grafik

layouts/partials/menu-bundle.html Outdated Show resolved Hide resolved
layouts/partials/menu-filetree.html Outdated Show resolved Hide resolved
xoxys
xoxys requested changes Jul 8, 2021
View reviewed changes
exampleSite/content/usage/configuration.md Outdated Show resolved Hide resolved
@Finkregh @xoxys
Apply suggestions from code review
8fb29be 
Co-authored-by: Robert Kaussow <xoxys@rknet.org>
@xoxys
Copy link
Member

xoxys commented Jul 10, 2021

Thanks again.

@xoxys xoxys merged commit 56a0d44 into thegeeklab:main Jul 10, 2021
@Finkregh Finkregh deleted the feature/collapse-all branch July 12, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoxys xoxys xoxys requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Finkregh @thegeeklab-bot @xoxys