Seo breadcrumbs #67
Seo breadcrumbs #67
Conversation
fix: replace markdownify with renderString to use render hooks (thegeeklab#65)
|
Thanks for your contribution. I've added some smaller adjustments:
@i7d3v3l0p3r Could you review my changes? |
| <div class="gdoc-page__header flex flex-wrap justify-between{{ if not $showEdit }} hidden-mobile{{ end }}{{ if (and (not $showBreadcrumb) (not $showEdit)) }} hidden {{ end }}" itemscope itemtype="http://data-vocabulary.org/Breadcrumb"> | ||
| <span> | ||
| <div class="gdoc-page__header flex flex-wrap justify-between{{ if not $showEdit }} hidden-mobile{{ end }}{{ if (and (not $showBreadcrumb) (not $showEdit)) }} hidden {{ end }}" itemprop="breadcrumb"> | ||
| <div> |
There was a problem hiding this comment.
@xoxys Maybe move div under {{ if $showBreadcrumb }} to prevent empty div block in DOM when $showBreadcrumb == false?
There was a problem hiding this comment.
I've moved it back to prevent content shift if breadcrumbs are disabled. The empty div is required for the flex box layout to keep the "Edit page" link on the right side.
There was a problem hiding this comment.
and for mobile device change justify-between to justify-content: flex-end?
There was a problem hiding this comment.
It's not just the mobile view, but should work now without the empty divs for both showBreadcrumb and showEdit.
There was a problem hiding this comment.
@xoxys thanks! 👍
xoxys
force-pushed
the
seo-breadcrumbs
branch
from
10779b0
to
5ee754b
Compare
Remade breadcrumbs that will work correct with Google Search and successful passed Google Search Live Test
