-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
estimate-focal-length does not work for 4K video #7
Comments
...Oh. Right. Of course it does! I will fix that. That's a bug, which should be easy to fix. The focal length estimation uses vanishing points to estimate the focal length. It extends the sides of the square tag and finds intersection. To combat numerical instabilities, when the intersection is "too far away," it gives up, assuming that the sides are parallel. But the value for "too far away" was determined empirically on a fullHD footage. It should scale with the frame size, which it doesn't (such a dumb oversight :D) . |
It should be fixed. Can you please confirm it? |
Now i don't even get results with the down scaled version. I am going to look into this later. |
Damnit. That makes no sense. |
Aha! I think I know. Is the tag small, or viewed mostly from the front? |
@Map94 poke |
It is working for me with 4K footage! Many thanks! |
I read #6 and filmed the footage according to the requirements. (.png, ~500 Frames)
Running --estimate-focal-length on the footage yields only one estimate != -1.
Down scaling the sequence to 25% of the original resolution does work and yields useful results.
Down scaling to 50% doesn't work either.
What is the optimal resolution to estimate the focal length?
Tracking on 50% with --focal-length-pixels {estimated focal length for 25% * 2} does work.
Maybe adding --focal-length-percent would be a nice addition to be independent from the actual resolution. Not sure whether this will work in general.
The text was updated successfully, but these errors were encountered: