Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adopt Greenwood strict mode #158

Merged
merged 4 commits into from Aug 13, 2020
Merged

adopt Greenwood strict mode #158

merged 4 commits into from Aug 13, 2020

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jul 23, 2020 •
edited

resolves #157 and upgrades to Greenwood v0.9.0

  1. Update selectors to support Greenwood strict mode
  2. In strict mode, Polyfills plugin is not needed

The inline <script> work around doesn't work in develop mode though 馃槩

Before

Screen Shot 2020-08-08 at 3 26 52 PM

After

Screen Shot 2020-08-08 at 3 26 26 PM

TODO

  1. Before / after benchmarks
  2. Delete polyfills plugin

@thescientist13 thescientist13 added enhancement New feature or request help wanted Extra attention is needed chore build stuff, deploy stuff, etc etc labels Jul 23, 2020
@thescientist13 thescientist13 self-assigned this Jul 23, 2020
@thescientist13 thescientist13 force-pushed the enhancement/issue-157-srict-ssg-mode branch from 494289f to fe9e92d Compare August 8, 2020 19:21
@thescientist13 thescientist13 changed the title [WIP] adopt strict mode adopt Greenwood strict mode Aug 8, 2020
@thescientist13 thescientist13 mentioned this pull request Aug 13, 2020
Closed
@thescientist13
Copy link
Member Author

Need to fix footers, per #161

@thescientist13
Copy link
Member Author

Will need to open a ticket for this caveat
ProjectEvergreen/greenwood#413

@thescientist13 thescientist13 removed the help wanted Extra attention is needed label Aug 13, 2020
@thescientist13 thescientist13 merged commit 6857b90 into master Aug 13, 2020
@thescientist13 thescientist13 deleted the enhancement/issue-157-srict-ssg-mode branch August 13, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
chore build stuff, deploy stuff, etc etc enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement strict / ssg mode
1 participant
@thescientist13