Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure our domain to IP resolution supports multiple possible IP ranges in checks #576

Open
mrchrisadams opened this issue Apr 24, 2024 · 0 comments
Labels
enhancement ip addresses python Pull requests that update Python code

Comments

@mrchrisadams
Copy link
Member

As detailed in PR #575, we updated the code we use for checking IP ranges to support ipv4 and ipv6 addresses by using a different socket method, socket.getaddrinfo when looking up a domain.

https://github.com/thegreenwebfoundation/admin-portal/pull/575/files

What we probably should do when a domain is looked up is check every possible ip address we get back from socket.getaddrinfo, and only return a green result if they all match.

This is here for us to revisit in future, so we don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ip addresses python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

1 participant