Change 2 booleans to 1 enum #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pwoolcoc The changes look good to me but both Travis and my own machine are telling that the latest rust nightly package have wreaked havoc on cargo. Testing with rustc 1.0.0-nightly (c4fe7d6ae 2015-02-23) (built 2015-02-24). Will check again later. |
|
I believe the last nightly broke cargo or something according to the PSA on reddit. |
|
Yea, I had to revert to 2015-02-22 to get cargo to work properly |
pwoolcoc
force-pushed
the
change-booleans-to-enum
branch
from
afc69ec
to
e58c1ed
Compare
|
I checked the travis build this morning, and it reminded me that I had forgotten to fix the tests :-/. So, I just pushed a fix for those, along with one more docs fix. |
|
@pwoolcoc Awesome, thanks a lot! |
pwoolcoc
force-pushed
the
change-booleans-to-enum
branch
from
e58c1ed
to
e9a621a
Compare
Closed
pwoolcoc
force-pushed
the
change-booleans-to-enum
branch
from
e9a621a
to
60a43e6
Compare
Since `socket.new_pollfd(false, false)` is not a particularly useful state to be in, change this API to use an enum instead of 2 booleans. This allows us to limit the API to only the states that are actually useful
pwoolcoc
force-pushed
the
change-booleans-to-enum
branch
from
60a43e6
to
e2e71e6
Compare
|
@blabaere all set! |
|
@thehydroimpulse I agree with Travis, we can safely merge PR #103. This would make the API more usable. |
thehydroimpulse
added a commit
that referenced
this pull request
Feb 28, 2015
Change 2 booleans to 1 enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
socket.new_pollfd(false, false)is not a particularly useful stateto be in, change this API to use an enum instead of 2 booleans. This allows
us to limit the API to only the states that are actually useful