Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The contents of documents in this.openedDocumentUris are never updated #63

Closed
keyboardDrummer opened this issue Sep 7, 2018 · 2 comments
Closed

The contents of documents in this.openedDocumentUris are never updated #63

keyboardDrummer opened this issue Sep 7, 2018 · 2 comments
Assignees
@akosyakov
Labels
bug

Comments

@keyboardDrummer
Copy link
Contributor

keyboardDrummer commented Sep 7, 2018 •
edited
Loading

On didChange requests, it seems like you don't update the contents of the document you store in memory, see the code.

Since you are using the document contents in several places, this seems like it would lead to bugs.

This is somewhat confirmed because I'm seeing faulty behavior when sending non-incremental didChange requests, which trigger calls to the contents of the stored document, here.
@keyboardDrummer keyboardDrummer mentioned this issue Sep 7, 2018
Closed
@akosyakov
Copy link
Contributor

Looks like a bug for sure. PRs are very welcomed. One can use TextDocument.applyEdits to implement it.

@akosyakov akosyakov self-assigned this Sep 10, 2018
akosyakov added a commit that referenced this issue Sep 10, 2018
@akosyakov
fix #63: update documents on did change
bb649ba 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@keyboardDrummer
Copy link
Contributor Author

Awesome to see such a quick fix :)

@akosyakov akosyakov mentioned this issue Sep 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akosyakov @keyboardDrummer