Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to latest monaco #115

Merged
merged 1 commit into from
Aug 27, 2019
Merged

upgrade to latest monaco #115

merged 1 commit into from
Aug 27, 2019

Conversation

akosyakov
Copy link
Contributor

fix #114

@akosyakov
Copy link
Contributor Author

Wait to merge before it tested in Theia: eclipse-theia/theia#5901

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Contributor Author

Published under dev tag for testing.

@akosyakov
Copy link
Contributor Author

@AlexTugarev Could you review it? PR in Theia to test: eclipse-theia/theia#5901

Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with the mentioned PR in Theia and it works nicely! cf. eclipse-theia/theia#5901 (comment)

@akosyakov akosyakov merged commit 167752c into master Aug 27, 2019
@DonnieWest DonnieWest deleted the ak/upgrade_monaco branch October 10, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code completion does not work with monaco newer than 0.14.6
2 participants