Return null when resolving completion request at an invalid location #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Open in Gitpod - starts a development workspace for this pull request in code review mode and opens it in a browser IDE. |
keyboardDrummer
force-pushed
the
typeFoxInvalidCompletionFix
branch
from
5335b57
to
b925824
Compare
akosyakov
reviewed
Oct 1, 2018
server/src/lsp-server.ts
Outdated
| return body.map(entry => asCompletionItem(entry, file, params.position, document)); | ||
| } catch (error) { | ||
| if (error.message === "No content available.") { | ||
| this.logger.warn('No content was available for completion request'); |
There was a problem hiding this comment.
Do we need to log? Clients will see them in the output panel, they are more noise than helpful.
There was a problem hiding this comment.
Well, could be useful for debugging. Do you prefer we make it this.logger.info ?
akosyakov
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return null when resolving completion request at an invalid location, as is allowed by the LSP spec. Before this CR, asking for a completion request at a location where no completions can be provided, such immediately after the
bin the codefunction b, would cause the server to return anErrorCodes.InternalError.The reason for this is that tsserver, when you ask for completions at a nonsense location, returns a response with
success === false(ref). We then reject the tsp request Promise (here), and this rejected Promise is never caught so it is later translated to an internal error.