Manually get XDG_CONFIG_HOME and drop pyxdg from dependencies
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop `pyxdg` as dependency and instead get `XDG_CONFIG_HOME` manually. The same way is being used as `pyxdg` does: https://gitlab.freedesktop.org/xdg/pyxdg/-/blob/bd999c1c/xdg/BaseDirectory.py#L37-L38 There is a name clash between the two packages `xdg` and `pyxdg`. See: https://gitlab.freedesktop.org/xdg/pyxdg/-/issues/24 As only that one environment variable is being used from the library it can just as good be expanded manually. This solves the confusion and problems for users who have both installed and it also reduces the dependency footprint. Also use `os.path.join` for `config_file`.
theironrobin
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
pyxdgas dependency and instead getXDG_CONFIG_HOMEmanually.The same way is being used as
pyxdgdoes:https://gitlab.freedesktop.org/xdg/pyxdg/-/blob/bd999c1c/xdg/BaseDirectory.py#L37-L38
There is a name clash between the two packages
xdgandpyxdg. See:https://gitlab.freedesktop.org/xdg/pyxdg/-/issues/24
As only that one environment variable is being used from the library
it can just as good be expanded manually.
This solves the confusion and problems for users who have both
installed and it also reduces the dependency footprint.
Also use
os.path.joinforconfig_file.