Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.4 Compile Warnings #45

Open
Edstub207 opened this issue May 24, 2024 · 2 comments
Open

5.4 Compile Warnings #45

Edstub207 opened this issue May 24, 2024 · 2 comments

Comments

@Edstub207
Copy link

Hello,

As of 5.4, there is the following compile warning:

11>EXEC: Warning : do not include Windows/PreWindowsApi.h directly. Use Windows/WindowsHWrapper.h or Windows/AllowWindowsPlatformTypes.h instead

I believe this stems from TurboLinkGrpcModule.cpp line 14

Unsure which is the correct include to use for Turbolink

@moonbusmike
Copy link

Try this:

#if PLATFORM_WINDOWS
#if defined(WINDOWS_H_WRAPPER_GUARD)
#error WINDOWS_H_WRAPPER_GUARD already defined
#endif
#define WINDOWS_H_WRAPPER_GUARD
#include "Windows/PreWindowsApi.h"
#endif

#include "grpc/grpc.h"
#include "grpc/support/log.h"
#include "google/protobuf/descriptor_database.h"

#if PLATFORM_WINDOWS
#include "Windows/PostWindowsApi.h"
#undef WINDOWS_H_WRAPPER_GUARD
#endif

@Edstub207
Copy link
Author

@moonbusmike Sadly that does not solve the compiler warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants