Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Info-ZIP Unicode Path Extra Field (0x7075) #33

Closed
f111fei opened this issue Jun 13, 2016 · 4 comments
Closed

support Info-ZIP Unicode Path Extra Field (0x7075) #33

f111fei opened this issue Jun 13, 2016 · 4 comments

Comments

@f111fei
Copy link

f111fei commented Jun 13, 2016

Download: https://github.com/f111fei/test-files/raw/master/yauzl-test-chinese.zip
Run: node index.js
Get Output:

c:\Users\xzper\Desktop\yauzl-test-chinese>node index.js
Current FileName: ╞▀╕÷╖┐╝Σ.txt

The correct name is 七个房间.txt

@f111fei
Copy link
Author

f111fei commented Jun 13, 2016

duplicate of #19

But There are some solutions to get correct names?

@thejoshwolfe thejoshwolfe changed the title Extract chinese files garbled support Info-ZIP Unicode Path Extra Field (0x7075) Jun 13, 2016
@thejoshwolfe
Copy link
Owner

thejoshwolfe commented Jun 13, 2016

I've determined that this issue is caused by yauzl not recognizing an optional extension to the spec where a zipfile creator can specify the filename in two places and one of them says to ignore the other. This is the first I've seen a zipfile creator use this feature, so I haven't thought to support it until now.

This seems like a useful extension to support.

@thejoshwolfe
Copy link
Owner

Your issue is fixed on master. However, I'd like to write some more tests before releasing this feature to npm.

@thejoshwolfe
Copy link
Owner

published to npm as version 2.6.0. please let me know if you have any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants