-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trap loosing focus in case focusable is portaled, within shards, and the last child of the body #225
Comments
This is more about feature rather a bug because frankly speaking being able to leave to the browser interface is often correct behavior. The expected solution for this is to wrap portalled content with Leave this to me... |
Greetings, Anton! Thank you for this tool :) The main problem here is that usually
Here is what happening:
BTW same behavior happens with having shard as first focusable child of the body, revealing itself on Shift+Tab. |
Yes. I tried FocusGuard too. They are not working, but might be improved to bugfix in this way: Underlined attributes is obligatory to make it work. Check this out: |
So there is a special component with roving tab index over focus guards, which makes them safe and easy to put where needed - https://github.com/theKashey/react-focus-lock/blob/master/src/FocusGuard.js#L18 They are not activating on time 🤷♂️ |
This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far. |
Steps to reproduce the issue:
Comments:
The text was updated successfully, but these errors were encountered: