Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbing in radio buttons are broken in FocusOn #35

Closed
sebpettersson opened this issue Mar 10, 2020 · 3 comments
Closed

Tabbing in radio buttons are broken in FocusOn #35

sebpettersson opened this issue Mar 10, 2020 · 3 comments
Assignees

Comments

@sebpettersson
Copy link

sebpettersson commented Mar 10, 2020

When using a radio button group inside FocusOn, keyboard tabbing is broken. When the focus is on a radio button the focus get "stuck" and doesn't move to the next element when pressing tab.

In the test case below, when the focus trap is enabled:

  • When the first radio button has focus, tabbing doesn't do anything. Shift + tab works and the focus is set to the button.

  • When the second radio button has focus, tabbing doesn't do anything. Shift + tab doesn't work either.

  • When the last radio button has focus, tabbing and shift + tab both work as expected.

Compare it to the second example with checkboxes which work correctly.

Test case

@theKashey
Copy link
Owner

Yeah, there is a special logic for radio buttons (they are a bit special), which is probably got broken a bit.

@theKashey theKashey self-assigned this Mar 11, 2020
@theKashey
Copy link
Owner

Related theKashey/react-focus-lock#103

@theKashey
Copy link
Owner

Fixed in v3.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants