Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib dependency not included #11

Open
eclazi opened this issue Mar 21, 2017 · 5 comments
Open

zlib dependency not included #11

eclazi opened this issue Mar 21, 2017 · 5 comments

Comments

@eclazi
Copy link

eclazi commented Mar 21, 2017

zlib is not included.

"This project does not have any external library dependencies. All (boost, thrift etc.) needed libraries are downloaded and built automatically, but you need enough free disk space to build all components"

Fails to build on Windows using CMake 3.7.2, MSVC 2015 x64

@thekvs
Copy link
Owner

thekvs commented Mar 21, 2017

Which component (serialization library?) fails to build?

@eclazi
Copy link
Author

eclazi commented Mar 21, 2017

Sorry, I mean't cmake fails.

The C compiler identification is MSVC 19.0.24215.1
The CXX compiler identification is MSVC 19.0.24215.1
Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe
Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe -- works
Detecting C compiler ABI info
Detecting C compiler ABI info - done
Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe
Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe -- works
Detecting CXX compiler ABI info
Detecting CXX compiler ABI info - done
Detecting CXX compile features
Detecting CXX compile features - done
Looking for pthread.h
Looking for pthread.h - not found
Found Threads: TRUE  
Performing Test CXX11
Performing Test CXX11 - Success
Looking for include file inttypes.h
Looking for include file inttypes.h - found
Looking for include file netinet/in.h
Looking for include file netinet/in.h - not found
Could NOT find ZLIB (missing:  ZLIB_LIBRARY) (found version "1.2.8")
CMake Error at CMakeLists.txt:39 (message):
  Couldn't find zlib library


Configuring incomplete, errors occurred!
See also "C:/Users/Joss/Documents/src/cpp-serializers/build/CMakeFiles/CMakeOutput.log".
See also "C:/Users/Joss/Documents/src/cpp-serializers/build/CMakeFiles/CMakeError.log".

@thekvs
Copy link
Owner

thekvs commented Mar 21, 2017

Oh.
Sorry, don't know much about Windows world. Do they have zlib at all?
Any patches are welcome!

@eclazi
Copy link
Author

eclazi commented Mar 21, 2017

Cool, will submit one at some point

@Ghospel
Copy link

Ghospel commented Oct 12, 2017

@Jossgray got a patch for this by any chance? I'm having the same issue trying to build on windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants