Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf usage not appropriate #21

Open
jl2922 opened this issue Dec 25, 2017 · 1 comment
Open

Protobuf usage not appropriate #21

jl2922 opened this issue Dec 25, 2017 · 1 comment

Comments

@jl2922
Copy link

jl2922 commented Dec 25, 2017

For Google's protobuf, when a significant portion of negative numbers is expected, use sint64 instead of int64 in the proto definition will make it run much faster and give a much smaller size.

@jl2922 jl2922 changed the title protobuf signed int encoding Protobuf usage not appropriate May 3, 2018
@earonesty
Copy link

In addition, protobuf does a lot of work during the "setter". To be fair, you need to include the set calls in the loop, not just the serialize call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants