Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement close() in the HttpManagementProxy #1385

Closed
Tracked by #1375
, #1326
...
adejanovski opened this issue Sep 5, 2023 · 1 comment · Fixed by #1400
Closed
Tracked by #1375
, #1326
...

Implement close() in the HttpManagementProxy #1385

adejanovski opened this issue Sep 5, 2023 · 1 comment · Fixed by #1400
Assignees
@emerkle826
Labels
done Issues in the state 'done'

Comments

@adejanovski
Copy link
Contributor

adejanovski commented Sep 5, 2023 •
edited
Loading

Project board link

Method signature:
public void close()

Probably a no op in this situation but maybe we need to unregister some notification related stuff.
@adejanovski adejanovski mentioned this issue Sep 5, 2023
Closed
16 tasks
@adejanovski adejanovski changed the title public void close() (probably a no op in this situation but maybe we need to unregister some notification related stuff) Implement close() in the HttpManagementProxy Sep 5, 2023
@adejanovski adejanovski mentioned this issue Sep 5, 2023
Closed
24 tasks
@adejanovski adejanovski added in-progress Issues in the state 'in-progress' and removed ready labels Sep 7, 2023
@emerkle826 emerkle826 mentioned this issue Sep 7, 2023
Merged
@emerkle826 emerkle826 linked a pull request Sep 7, 2023 that will close this issue
Remove close from proxy interface #1400
Merged
@adejanovski adejanovski added ready-for-review Issues in the state 'PVTI_lADOBFnRAs4AH-xYzgDXgVA' and removed in-progress Issues in the state 'in-progress' labels Sep 7, 2023
@emerkle826 emerkle826 self-assigned this Sep 7, 2023
@adejanovski adejanovski added review Issues in the state 'review' done Issues in the state 'done' and removed ready-for-review Issues in the state 'PVTI_lADOBFnRAs4AH-xYzgDXgVA' review Issues in the state 'review' labels Sep 8, 2023
@Miles-Garnsey
Copy link
Contributor

Merged to main here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerkle826 emerkle826

Labels
done Issues in the state 'done'
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove close from proxy interface thelastpickle/cassandra-reaper
3 participants
@emerkle826 @adejanovski @Miles-Garnsey