Remove takeColumnFamilySnapshot(String var1, String var2, String var3) from HttpManagementProxy, JmxCassandraManagementProxy, ICassandraManagementProxy

[adejanovski]

Project board link

Method signature:

public void takeColumnFamilySnapshot(String var1, String var2, String var3) throws IOException

[emerkle826]

This one will be a bit more involved. Management API client supports taking snapshots at the table/column family level, but Reaper does not:

The code here takes a query parameter for tables:
https://github.com/thelastpickle/cassandra-reaper/blob/master/src/server/src/main/java/io/cassandrareaper/resources/SnapshotResource.java#L70-L78

However that parameter is never passed to the snapshot service:
https://github.com/thelastpickle/cassandra-reaper/blob/master/src/server/src/main/java/io/cassandrareaper/resources/SnapshotResource.java#L86-L102

Furthermore, the snapshot service doesn't even seem to support table names:
https://github.com/thelastpickle/cassandra-reaper/blob/master/src/server/src/main/java/io/cassandrareaper/service/SnapshotService.java#L85
https://github.com/thelastpickle/cassandra-reaper/blob/master/src/server/src/main/java/io/cassandrareaper/service/SnapshotService.java#L95-L100

[adejanovski]

@emerkle826, this is low priority, we can deal with this later.

[Miles-Garnsey]

This method actually doesn't appear to be used. It is called once in takeColumnFamilySnapshot in the SnapShotProxy, but that method itself is never called.

Suggest we make this ticket about removing this method from the codebase entirely.

[adejanovski]

works for me 👍