Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the relationship between the MetricsProxy and the CassandraManagement classes #1423

Open
adejanovski opened this issue Oct 3, 2023 · 0 comments

Comments

@adejanovski
Copy link
Contributor

adejanovski commented Oct 3, 2023

Project board link

The addition of the management api as communication protocol between Reaper and Cassandra changed the relationship between the management interface and the metrics proxy one.
With JMX, both operations and metrics were pulled from the same place: JMX MBeans
Thus, pulling metrics was done in the JMXProxy, and the MetricsProxy was using it for that.
With the management api, we have two distinct endpoints for operations and metrics, and the relationship between the management proxy class and the metrics proxy class is turned the other way around: the management proxy now goes through the metrics proxy to pull the metrics, while with jmx it was the metrics proxy that was going through the management proxy to get the metrics.
We need to refactor the relationship between these two classes and possibly fully remove the concept of a Metrics proxy, merging it into the management proxy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant