Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: webui will generate a huge number of requests if _refreshClusterStatus keep getting error responses #1442

Closed
upsilon2gamma opened this issue Nov 29, 2023 · 0 comments · Fixed by #1443
Labels
done Issues in the state 'done'

Comments

@upsilon2gamma
Copy link
Contributor

upsilon2gamma commented Nov 29, 2023

Project board link

https://github.com/thelastpickle/cassandra-reaper/blob/master/src/ui/app/jsx/cluster-list.jsx#L52-L71

According to JQuery doc (https://api.jquery.com/jQuery.ajax/), complete function will be called whether the ajax request succeeds or fails. As a result, _refreshClusterStatus will set two new scheduled calls if the ajax request gets an error response (the first one by error and the second one by complete).

If _refreshClusterStatus keeps getting error responses (e.g. token has expired, the ajax request always gets 304 response), it will generate a huge number of requests in 10min (doubles every 30s)

@adejanovski adejanovski added the done Issues in the state 'done' label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Issues in the state 'done'
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants