Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated config missing home option #62

Closed
dideler opened this issue Feb 27, 2017 · 3 comments
Closed

Generated config missing home option #62

dideler opened this issue Feb 27, 2017 · 3 comments
Assignees
Labels

Comments

@dideler
Copy link

dideler commented Feb 27, 2017

While trying to configure the default HOME location, I noticed the config that's autogenerated to ~/.lounge/config.js is missing the home option that's specified in the config docs.

It's unclear to me what the desired behaviour is. Is this option deprecated and the docs are outdated? Or are the docs correct and the option should be included in the config?

@astorije
Copy link
Member

Hey @dideler! Browsing the history, I can't even find where that option was removed. I can't even tell you for sure if it has ever been a thing :D

So to answer your question, yes this option is unsupported and I have even removed it in the complete doc rewrite that I'm actively working on right now.

Regarding the desired behavior, well, that's precisely why this option would be so broken: it's a field in the configuration file to instruct The Lounge where to look for... the configuration file!
There are 2 alternatives to this at the moment: either use the --home CLI option (lounge start --home /etc/lounge/) or the $LOUNGE_HOME environment variable (LOUNGE_HOME=/etc/lounge lounge start). Happy to hear suggestions to improve this.

@astorije astorije added the bug label Feb 28, 2017
@astorije astorije self-assigned this Feb 28, 2017
@dideler
Copy link
Author

dideler commented Feb 28, 2017

Yeah you're right, realised that the suggested Procfile for Heroku specifies the home path:

web: node index --private --home /app

Didn't know about the LOUNGE_HOME env var, thanks.

I'll leave this issue open so it can be resolved when your docs branch is merged.

@astorije
Copy link
Member

Just an FYI, as of upcoming v2.5.0, --home will be deprecated in favor of the LOUNGE_HOME environment variable.
There will also be a .lounge_home file in the folder where The Lounge is installed, but while anyone can edit this, it is more intended for package installers that install in non-default locations, like https://github.com/thelounge/deb-lounge in /etc/lounge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants