Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knx.configured() returns true too early #5

Closed
Bernator opened this issue Nov 4, 2018 · 4 comments
Closed

knx.configured() returns true too early #5

Bernator opened this issue Nov 4, 2018 · 4 comments

Comments

@Bernator
Copy link
Contributor

Bernator commented Nov 4, 2018

During ETS configuration knx.configured() returns true even before restart of mc finished configuration procedure.

@thelsing
Copy link
Owner

thelsing commented Nov 5, 2018

I just pushed some changes that should resolve this. But now I'm not sure if this is necessary. What is the harm in returning true before restart? After Loading group address table, association table, group object table and application program the device is configured. Sure ETS sends an restart command next but that should not be necessary.

@Bernator
Copy link
Contributor Author

Bernator commented Nov 6, 2018

In my case the application program gets initialized during setup() with some ETS Parameters, this is only possible if the device is configured. So if there is no configuration at startup the app is not getting initialized.
Further if knx.configured() returns true later in loop() without restart, the uninitilaized app is getting started for a short time until the restart comes. In my case the app hang and the restart was never processed.
Sure it would be possible to fix the app and do nothing in this case and wait for the restart but i think it is much more intuitive when the stack returns true only after the restart.
Back answer, what is the benefit of returning true before restart? :)

@thelsing
Copy link
Owner

thelsing commented Nov 6, 2018

Ok, seems like a valid reason for me. Can you test if it works correctly now?

@Bernator
Copy link
Contributor Author

Bernator commented Nov 6, 2018

yes it works as expected, thx

@thelsing thelsing closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants