Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add the padding to ImplicitlyAnimatedList #30

Closed
lucasjinreal opened this issue Jun 3, 2021 · 5 comments
Closed

[feature] Add the padding to ImplicitlyAnimatedList #30

lucasjinreal opened this issue Jun 3, 2021 · 5 comments

Comments

@lucasjinreal
Copy link

https://github.com/bnxm/implicitly_animated_reorderable_list/issues/77#issuecomment-853332816

After a long discussion with this lib author, it seems can set the padding value to ImplicitlyAnimatedList.
My proposal is can you consider expose this params out so that users can choose to set it or not? thanks.

@jonasN5
Copy link
Owner

jonasN5 commented Jun 3, 2021

Sure I can. But have you tested it?

@lucasjinreal
Copy link
Author

@themadmrj I haven't Sir. Can u indicates me where put the params is OK, let me test it on my side first since only my APP have this weired usage.

@jonasN5
Copy link
Owner

jonasN5 commented Jun 3, 2021

You don't need a change in the library. Just change the code in your cache to test it. If it solves your problem, I'll make the change in the lib.

@lucasjinreal
Copy link
Author

lucasjinreal commented Jun 4, 2021

@themadmrj Don't understand. I mean which class I need change to the chatui.... regardless of change lib or cache on my local...

@jonasN5
Copy link
Owner

jonasN5 commented Jun 4, 2021

I'm just saying I'm waiting for you to test the solution to check whether it works, before I change the library... From what I could read in your discussion in the other library, you discussed it, but nobody tested it even once!

@jonasN5 jonasN5 closed this as completed Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants