Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https github links not supported #3

Open
cweiske opened this issue Aug 16, 2013 · 4 comments
Open

https github links not supported #3

cweiske opened this issue Aug 16, 2013 · 4 comments

Comments

@cweiske
Copy link

cweiske commented Aug 16, 2013

Links to https://github.com/username are not supported:

None of your providers are supported. Tried https://github.com/cweiske.

When changing the link to http://, I get further (see next issue).

@tomlarkworthy
Copy link

When I use my github profile it seems to check everything else BUT the github identity provider. So it seems to special case the starting node which leads it astray

image

@tomlarkworthy
Copy link

Sorry my report is not the same issue. If try from my homepage I see

image

So Github is not supported (thats ok) but in the first case when I sue my github profile it does not consider it a candidate provider at all.

@tomlarkworthy
Copy link

FROM http://microformats.org/wiki/RelMeAuth#detailed_algorithm

start with a user identity URL (e.g from the UI, or from a cookie from previous login etc.)
if the URL is an OAuth provider
then try authenticating with it (we prefer the user's own site for auth)
if it succeeds, exit
if canceled, exit
otherwise continue

So it seems it shoudl have tried to authenticate with the github profile ID right off the bat in step 2.

@tomlarkworthy
Copy link

Closer inspection of the source reveals it did try it, but for a less serious bug, it does not print out in the error message that it tried

// first try to authenticate directly with the URL given

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants