Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control via MQTT #18

Open
evranch opened this issue Dec 6, 2022 · 2 comments
Open

Control via MQTT #18

evranch opened this issue Dec 6, 2022 · 2 comments

Comments

@evranch
Copy link

evranch commented Dec 6, 2022

Hey, I've been using JAKYM to play music around the farm via a USB FM transmitter.

To make it convenient to control from a phone, I threw together a simple Python wrapper to control it with a MQTT dashboard instead of having to SSH into the server.

https://github.com/evranch/jakym_mqtt

Wondering if you'd be interested in MQTT functionality in the main program, if so I could probably add it fairly easily and send you a PR.

@themayankjha
Copy link
Owner

Wow! that's a use case I would have never seen coming.

I would very happily Accept your PR as easy remote control of the program can easily translate into multiple use cases however I do think that it should be optional i.e. MQTT shouldn't always be running and should only run in case a user specifes due to its overheads.

Looking forward for your PR and Thanks for using my program !

@evranch
Copy link
Author

evranch commented Dec 9, 2022

Sounds good, I'm thinking just a command line option to supply the server location and login info if needed should probably do it. It doesn't look like you're using any persistent config file where something like that could be stored.

MQTT is incredibly lightweight (I use it to let all my IOT/embedded stuff talk to each other here) but I agree it's good design philosophy to minimize overhead. Very easy to do as well because the whole library runs in its own thread, so if no MQTT needed, don't start the thread.

I'll get on it next time I'm trapped indoors on a freezing day and send you the PR, happy to contribute. JAKYM is a great lightweight streaming player!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants