Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Storybook #195

Open
zoltanszogyenyi opened this issue Jul 6, 2022 · 4 comments
Open

Integrate Storybook #195

zoltanszogyenyi opened this issue Jul 6, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@zoltanszogyenyi
Copy link
Member

We need to integrate the UI components with Storybook so we can run tests for accessibility and functionality as the library grows in size and adoption.

@zoltanszogyenyi zoltanszogyenyi added enhancement New feature or request help wanted Extra attention is needed labels Jul 6, 2022
@zoltanszogyenyi zoltanszogyenyi self-assigned this Jul 6, 2022
@mouracamila
Copy link

Hi @zoltanszogyenyi, I can help with this :)

@zoltanszogyenyi
Copy link
Member Author

zoltanszogyenyi commented Jul 7, 2022

Hey @mouracamila,

Oh, awesome! I've already finished most of the button component, but I'm still setting up some tests with Jest.

But I think that you can pick a component for integration, for example the badge. (colors, sizes, styles).

We can talk on the #main-library channel on the Discord Server.

The branch is currently /storybook.

I guess that we should create PR's into the storybook branch and when that's done merge it with develop.

@AndrewBBx
Copy link

Hi @zoltanszogyenyi, I can help with this :)

Could you help me with this too?)

@zoltanszogyenyi
Copy link
Member Author

Hey @AndrewBBx,

We have a branch called Storybook - I think you can merge the current master into it and continue working on the new components form there if you'd like - you can also join our Discord to discuss in more depth :)

Cheers,
Zoltan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Development

No branches or pull requests

3 participants