Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subdirectory for components, containers & pages #215

Open
rgstephens opened this issue Dec 25, 2016 · 4 comments
Open

Subdirectory for components, containers & pages #215

rgstephens opened this issue Dec 25, 2016 · 4 comments
Labels

Comments

@rgstephens
Copy link

I'd like to see a documents subdirectory for ui/components, containers & pages in the same way the api has a documents subdirectory. When I create a new project with Base and starting making new collections and related UI components, I create a subdirectory for each new collection under both api and the ui directories.

@arthurkirsz
Copy link

Make sense to me. When the app grows, I always struggle organising with Base

@rgstephens
Copy link
Author

I submitted pull request #216 with the changes along with a related request, pull #217, to change the filenames for easier extension of Base.

@arthurkirsz
Copy link

Had a quick look. I like it but Ryan might not merge the PRs. The current structure is very clear for beginners whereas the new one could make less sense.what do you think Ryan ?

@themeteorchef
Copy link
Owner

Hi @rgstephens @arthurkirsz. Agree with Arthur here. I do prefer this more personally, but I want to keep things as close to the Meteor Guide/simple as possible. Something like an extra directory may seem like a silly thing to split hairs over, but—especially for beginners—it introduces the added question of "do I have to do it this way?"

Going to think about this and flag it as a consideration for Base 5.0. Thanks for submitting this, Greg :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants