Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore spurious error messages when calling ddcutil #10

Merged
merged 1 commit into from Jun 30, 2020
Merged

ignore spurious error messages when calling ddcutil #10

merged 1 commit into from Jun 30, 2020

Conversation

1player
Copy link
Contributor

@1player 1player commented Jun 30, 2020

Fixes #9

I'm new with GJS, I had a hard time telling spawn_async_with_pipes to ignore stderr, but I seem to understand Gio.Subprocess.new is preferrable nowadays, and the code is simpler anyway.

This commit makes so only the stdout is sent to the callback, and stderr, which might include benign error messages, is ignored and doesn't trip the parser.

@daitj daitj merged commit 8714d6b into daitj:master Jun 30, 2020
@daitj
Copy link
Owner

daitj commented Jun 30, 2020

@1player No worries, I am in the same boat. I have had hard time to find right implemenation because of constant updates to GJS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension only shows "Initializing"
2 participants