Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make onKeyDown logic more readable #918

Closed
jamesmaa opened this issue May 12, 2024 · 1 comment
Closed

Make onKeyDown logic more readable #918

jamesmaa opened this issue May 12, 2024 · 1 comment

Comments

@jamesmaa
Copy link
Collaborator

The logic in search-display-controller.js's onKeyDown logic is difficult to reason about. Task is to either simplify this logic or make it easier to read/reason about. A test or some way to verify it preserves behavior is very ideal

Related discussion: https://github.com/themoeway/yomitan/pull/914/files#r1597534169

@brandonrainey
Copy link

Thanks for putting up these good-first-issues! I have a easier to reason about version made, just trying to figure out writing a test for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants