Skip to content
This repository has been archived by the owner on Apr 5, 2020. It is now read-only.

Huge bundle size of everyone who use this library #10

Closed
amerllica opened this issue Jul 17, 2019 · 1 comment · Fixed by #11
Closed

Huge bundle size of everyone who use this library #10

amerllica opened this issue Jul 17, 2019 · 1 comment · Fixed by #11
Labels
bug Something isn't working

Comments

@amerllica
Copy link
Collaborator

By destructuring import of the Close icon of Material-UI in the supplier.js file, I faced a huge bundle of my project. something about 5mg 😮

For a test, I omit all of my libraries and based on Tree Shaking docs of Webpack I implement the tools and tricks in my project but bundle has no change until I fount the issue and 1 percent I don't think it is material-snackbar-supplier causes to this damn bundle.

Based on this material-ui doc the importing of the Close icon should change to:

import CloseIcon from '@material-ui/icons/Close';

So as fast as I can I send a PR, and please assign the bug tag to this issue and review and merge my PR and please as fast as you can release a new version.

Thanks a lot bro.

@themojilla
Copy link
Owner

I'm wondering why you even change that before.
It's my bad, I should have told you before.
In addition, there is a related optimization article in material docs which is well-eplained too

@themojilla themojilla added the bug Something isn't working label Jul 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants